Mixaill / galaxy-integration-gw2

GOG Galaxy 2.0 Guild Wars 2 integration
MIT License
17 stars 3 forks source link

Add functionality to Install method #5

Closed FriendsOfGalaxy closed 4 years ago

FriendsOfGalaxy commented 4 years ago

Hey,

currently there is no way to install, or start the installation process of GW2 through its integration, my suggestion would be to instead of returning None at least open up the 'https://account.arena.net/welcome' webpage in default browser which has this screen image

This would be a quick change from this:

 async def install_game(self, game_id):
        if game_id != self.GAME_ID:
            logging.warn('plugin/install_game: unknown game_id %s' % game_id)
            return

to something like this:

import webbrowser
 async def install_game(self, game_id):
        webbrowser.open('https://account.arena.net/welcome')

Hope this is of help.

Mixaill commented 4 years ago

Fixed in 789704cdf84c2d90739a78cb775cc0270bb24a54