search

MixedRealityToolkit / MixedRealityToolkit-Unity

This repository holds the third generation of the Mixed Reality Toolkit for Unity. The latest version of the MRTK can be found here.
BSD 3-Clause "New" or "Revised" License
374 stars 96 forks source link

Unit tests for MRTK3 Solvers #224

Open IssueSyncBot opened 1 year ago

IssueSyncBot commented 1 year ago

Original issue opened by:

@RogPodge @RogPodge

Tracks creating new unit tests for MRTK3 solvers

ISSUE MIGRATION

Issue migrated from: https://github.com/microsoft/MixedRealityToolkit-Unity/issues/11220

IssueSyncBot commented 1 year ago

Original comment by:

@srinjoym srinjoym

Investigation update: There are currently no tests for solvers. Looks like there's about ~12 solvers we'd need to write independent tests to complete this work. These solvers are just direct carry overs from MRTK 2 as far as I can tell, so no new functionality to validate for GA. I'm not sure that effort will be worth it, especially if we move to the new Transformations based solver system that was WIP.

If we do decide to write unit tests, we should split this task into smaller tasks based on each individual solver and estimate time accordingly. I'd estimate about 2 weeks to write tests for all of them, so I've updated the time estimate on this task to reflect that. The other option is to write tests as we fix bugs in the solvers

IssueSyncBot commented 1 year ago

Original comment by:

@srinjoym srinjoym

Started some of this work with an initial set of tests for the SolverHandler script in this PR #11441

IssueSyncBot commented 1 year ago

Original comment by:

@AMollis AMollis

The MRTK3 Solver system will be replaced with a new Transformation system. Given this, unit tests for the older Solver system are less of a priority. We will continue to create new unit tests for Slovers if their are bug fixes in the area.