search

MixedRealityToolkit / MixedRealityToolkit-Unity

This repository holds the third generation of the Mixed Reality Toolkit for Unity. The latest version of the MRTK can be found here.
BSD 3-Clause "New" or "Revised" License
374 stars 96 forks source link

Official Support for "Enter Play Mode Settings" without domain reload #296

Open IssueSyncBot opened 1 year ago

IssueSyncBot commented 1 year ago

Original issue opened by:

@TheOnlyMunk @TheOnlyMunk

Describe the problem

I'm always frustrated when [...]

I enter play mode and it takes 10+ seconds to start.

Describe the solution you'd like

Would love for MRTK to officially support the option under Project Settings -> Editor- > Enter Play Mode Options (true) -> Reload Domain (false) + Reload Scene (false).

image

When toggling off "Reload Domain" I get a bunch of errors.

Describe alternatives you've considered

Not having fast iteration times or try to dig deep into the MRTK architecture to solve manual reloads myself. Wanted to hear whether it's something that is already being looked into or not.

ISSUE MIGRATION

Issue migrated from: https://github.com/microsoft/MixedRealityToolkit-Unity/issues/10724

IssueSyncBot commented 1 year ago

Original comment by:

@Zee2 Zee2

I believe this is something that's actually blocked by the underlying input system, and other deeper things out of our control... Most of the time when I've tried to do a no-reload change, it's been non-MRTK things complaining (input system, XR plugins, etc...)

IssueSyncBot commented 1 year ago

Original comment by:

@AMollis AMollis

@shaynie anything we can do anything here?

TheXRMonk commented 1 year ago

Original comment by:

@Zee2 Zee2

I believe this is something that's actually blocked by the underlying input system, and other deeper things out of our control... Most of the time when I've tried to do a no-reload change, it's been non-MRTK things complaining (input system, XR plugins, etc...)

Just wanted to clarify that this is definitely not true. We've been running a custom version of the latest MRTK 2 without domain reload for a year now without issues so it's definitely possible. Just have to make sure static fields are reset and events unsubscribed.

Maesla commented 4 months ago

This is very important for fast iteration and development speed. Even minor functionalities like UGUI input adapter doesn't work

  1. Create empty scene
  2. Add MRTK XR Rig and MRTKInputSimulator
  3. Add a sphere with Object Manipulator and UGUIInputAdapterDraggable
  4. Play the scene and move the sphere with the mouse. It works
  5. Enable "Enter Play Mode Settings" with Reload Domain unchecked
  6. Play the scene. Try to move the sphere with the mouse. It doesn't work
  7. See all the console warnings