Closed ahmed-shariff closed 5 months ago
Changing GazePinchInteractor.DependentInteractor
to XRBaseInteractor
is passing all test on the master branch. I can submit a PR with the fix if that makes sense.
@ahmed-shariff , please make a PR if you are able to unblock yourself. However, we are aware that XRI 3.0 has breaking changes that need to be addressed in MRTK3 (Feature Issue Pending).
@AMollis if there is any part I could help with addressing the XRI changes, please feel free to let me know. I'd be happy to help.
We're looking into the best approach to fix this issue. Please stay tuned for updates
Duplicate of #645
Describe the bug
When upgrading to XRI 3.0.0-pre.1 I get the following error:
Additional context
In XRI 3.0.0
XRBaseControllerInteractor
is being deprecated and replaced withXRBaseInputInteractor
(https://docs.unity3d.com/Packages/com.unity.xr.interaction.toolkit@3.0/changelog/CHANGELOG.html).Potential fix
Looking through the code,
GazePinchInteractor.DependentInteractor
can be aXRBaseInteractor
as only theIXRInteractor.GetValidTargets
is being used inGazePinchInteractor
. BothXRBaseControllerInteractor
andXRBaseInputInteractor
extend this as well. This also should not conflict withGazeInteractor
as it extendsXRRayInteractor
, which is extending the appropriate class on both version (XRBaseControllerInteractor
in 2.5.2 andXRBaseInputInteractor
in 3.0.0-pre.1)