Endless stream of error messages in Unity Editor when a GO with a PressableButton is selected

MixedRealityToolkit / MixedRealityToolkit-Unity

This repository holds the third generation of the Mixed Reality Toolkit for Unity. The latest version of the MRTK can be found here.

BSD 3-Clause "New" or "Revised" License

339 stars 86 forks source link

Endless stream of error messages in Unity Editor when a GO with a PressableButton is selected #772

Open KevinKennedy opened 1 month ago

KevinKennedy commented 1 month ago

Repro:

git checkout uxcore-v3.2.1
Open up the MRTKDevTemplate Unity project - Unity 2022.3.20f1
Open up the HandInteractionExamples scene
Select a GameObject with a PressableButton component (like BasicPressableButton)

Result:

In the Unity Console, you get a per-frame stream of "The serializedObject should not be used inside OnSceneGUI or OnPreviewGUI. Use the target property directly instead.". This overwhelms the Unity Editor and some background tasks become very slow.

Commenting out the "[CanEditMultipleObjects]" in PressableButtonInspector.cs will make the errors go away. Not the right fix obviously.

Looks like it was introduced in Change #698

ms-RistoRK commented 1 month ago

Hello @KevinKennedy, thank you for submitting this issue. I am trying to reproduce it but I am not able to reproduce the issue. In order to attempt to reproduce it I:

Made a clean clone of MRTK3 with the latest commit.
Confirmed that I have UXCore Package 3.2.1 as in:
Updated Unity Editor version to 2022.3.33f1
Opened HandInteractionExamples
(In both Editor and Play modes) Selected BasicPressableButton GameObject
... but the console does not flood with "The serializedObject should not ..." messages as in:

Here is my working branch in case you would like to try it: https://github.com/ms-RistoRK/MixedRealityToolkit-Unity/tree/MRTK3-Issue772

I would suggest you to:

Update your Unity Editor to 2022.3.33f1
Update your local repo with latest MRTK3 main branch commits

Could you please confirm if any of the above suggestions fixed your issue?

ms-RistoRK commented 1 month ago

Hello @KevinKennedy I took another look at this issue and now tried to reproduce it with Unity 2022.3.20f1 as per your report. I'm still unable to reproduce it in either Editor nor Play mode as shown next:

I'm thinking it may be the last commit you have from main branch. I'm using the latest commit from main branch. Could you please share which commit do you have? I'll try to reproduce from that commit.

KUNGERMOoN commented 3 weeks ago

I managed to reproduce it in my issue #782

KalonMailh commented 1 week ago

Hello There, I am facing the same issue. Do we have any more information about it ?

Custom Unity project - Unity 2022.3.34f1
MRTK UX Core Scripts 3.2.1
MRTK Last version of each package, proposed by the package Manager
Using ActionButton Prefab

So4E commented 2 days ago

I have the same issue. Here's a way to reproduce the errors:

Created a new Unity 3D project (version 2022.3.11f1 LTS)
Created a new scene in Unity and imported all mrtk 3 components with Microsoft Mixed Reality Feature Tool as described by Microsoft here
deleted camera and put MRTK XR Rig and MRTK InputSimulator into the scene
added a nearMenuBase prefab to my scene and edited the buttons (took the first actionButton, duplicated it and changed icons and labels)
errors keep popping up: