MixinNetwork / flutter-plugins

🧱 Flutter plugins used in Mixin Messenger.
MIT License
446 stars 192 forks source link

[desktop_webview_window] [Flutter 3.22.0] App crashes on windows when webview is closed #363

Open anirudhJG opened 2 months ago

anirudhJG commented 2 months ago

App crashes when webview is closed from method channel API

Reproduce Steps

Steps to reproduce the behavior: 1.Update to Flutter version 3.22.0

  1. Close from the close API method channel
  2. Notice App crashing
  3. Message is Exception thrown at 0x00007FFF7DF25CB4 (flutter_windows.dll) in App.exe: 0xC0000005: Access violation reading location 0x00000000000002F0.

Expected behavior

App should not crash

Version (please complete the following information):

isaacy13 commented 1 month ago

I'm getting same issue, it's reproducible ~5% of the time close() is called

It's consistently pointing to flutter_windows, while another thread is consistently pointing to destructor of either desktop_webview_window or desktop_multi_window

Admittedly I got a weird setup going on (intermixing both plugins), but seems like others are also getting this issue

desktop_webview_window example:

image image

desktop-webview-window-symbolicated.txt

desktop_multi_window example:

image image

desktop-multi-window-symbolicated.txt

Flutter Version: 3.22.3, Dart 3.4.4 OS: Windows plugins: desktop_webview_window, desktop_multi_window

isaacy13 commented 1 month ago

Updated Flutter SDK to stable channel (Flutter 3.24.3, Dart 3.5.3 at time of writing)

Could be placebo, but it feels more stable (still replicated crash once, but A LOT harder to reproduce now)

Seems like flutter_windows.dll is root cause (Flutter SDK issue & not plugin issue), I'd suggest any folks running into this issue to try upgrading their Flutter SDK

EDIT: seems like there's a lead here. New Flutter engine code might be breaking change for desktop_webview_window when chance, I will try either downgrading Flutter < 3.22 or testing out playground patch

https://github.com/flutter/flutter/issues/155685#issuecomment-2428360798 https://github.com/flutter/flutter/issues/155685#issuecomment-2430293157

isaacy13 commented 1 month ago

Has been reported by another individual to Flutter before https://github.com/flutter/flutter/issues/152299 https://github.com/flutter/flutter/issues/155685

Other threads https://github.com/MixinNetwork/flutter-plugins/issues/352