search

MixinNetwork / kraken

🐙 High performance WebRTC SFU implemented with pure Go.
Apache License 2.0
334 stars 49 forks source link

suspicious comparison in engine/peer.go #1

Closed josharian closed 4 years ago

josharian commented 4 years ago

https://github.com/MixinNetwork/kraken/blob/221733d5bf764c9a1c6da5df61ee2937581b1dd1/engine/peer.go#L336

Should this be next+uint32(gap) > 65535 instead of > 65536?

cedricfung commented 4 years ago

I agree 👍

this repo is really a mess, no docs, no tests yet.

josharian commented 4 years ago

I'm still learning things from reading the code, though. :) Not that I would object to docs or tests, of course.

cedricfung commented 4 years ago

Docs will be ready within 24 hours. Feel free to submit issues and PR.

Thank you