MixinNetwork / kraken

🐙 High performance WebRTC SFU implemented with pure Go.
Apache License 2.0
334 stars 49 forks source link

NACK (question) #19

Closed ldenoue closed 2 years ago

ldenoue commented 3 years ago

In Sean Dubois's broadcast example https://github.com/pion/webrtc/blob/master/examples/broadcast/main.go#L137 there's a loop to constantly read the sender (after AddTrack) using rtcpBuf := make([]byte, 1500)

Why don't we need to do the same with Kraken? Is it because it's done somewhere else, like in the interceptor.Registry in router.go?

cedricfung commented 3 years ago

We have that in old code, after upgraded to pion v3, the nack interceptor just does the work.

cedricfung commented 3 years ago

https://github.com/MixinNetwork/kraken/commit/a40dd99228f313e3fc433534ea0b5f9e011dbc5d