search

MixinNetwork / libsignal_protocol_dart

Signal Protocol library for Dart/Flutter
https://pub.dev/packages/libsignal_protocol_dart
GNU General Public License v3.0
159 stars 42 forks source link

IdentityKeyStore getIdentity returns nob-nullable IdentityKey #50

Closed ffpetrovic closed 2 years ago

ffpetrovic commented 2 years ago

https://github.com/MixinNetwork/libsignal_protocol_dart/blob/master/lib/src/state/identity_key_store.dart#L14

Should it return IdentityKey? instead of IdentityKey? What if that identity with that address doesn't exist?

crossle commented 2 years ago

Yes, I think should be IdentityKey?

crossle commented 2 years ago

Fixed on 2662bebed5e77ab76db608552069bf0440ca611e

ffpetrovic commented 2 years ago

Thank you

crossle commented 2 years ago

Any PR welcome.