MiyooCFW / gmenu2x

Front-end launcher used as the main one on the custom firmware
GNU General Public License v2.0
30 stars 28 forks source link

Some GMenu2X messages are missing from the translation file #43

Open MayanKoyote opened 11 months ago

MayanKoyote commented 11 months ago

While I was playing with the settings, checking that the translation parts matched each other and stuff, I noticed several untranslated (not translatable) messages:

  1. Time settings screen called up by long pressing on "X" button - these are the lines "SW Clock" and "Set system's software clock": s001

  2. Message "This directory is empty" when launching selector browser if the assigned directory is empty and changing directories is not allowed: s002

  3. Message "Add to Favorites" in the selector browser on any of the files inside the assigned directory: s003

  4. The message itself "Screenshot saved" when pressing "SELECT" + "START" buttons. (I can't take a screenshot of this message)

If to add these lines (and their translation) to the translation file by yourself, the translation appears. Since they are not difficult to reach while going through the settings, it would be nice to add them to the translate.txt file permanently.

Apaczer commented 11 months ago

Thanks, the following entries will be added:

CHEATER! ;)=
SW Clock=
Set system's software clock=
This directory is empty=
Add to Favourites=
Screenshot saved=

If you find anything more, please let me know!

While quickly testing I found also that some things can't be translated with current code:

Until I fix above I'll post pone any changes for now.

Apaczer commented 11 months ago

it would be nice to add them to the translate.txt file permanently.

@MayanKoyote - they have been added, but let us keep this issue open for ppl to know about mentioned translation issues.

MayanKoyote commented 11 months ago

Since things have gone well with favourites, it would be nice to add line: Link created= This is the message that appears when you add something to your favourites. Manual addition shows that it's translatable.

And also the remaining viewers: viewers so strings from dictionary.txt are: Image viewer= Pan= Text viewer= Zip content=

Apaczer commented 11 months ago

Indeed, thanks I can see it in dictionary.txt. There is still small issue with text wraping which I'm investigating (will add missing string after fix).

"ярлык создано"?

MayanKoyote commented 11 months ago

Ярлык создан

MayanKoyote commented 11 months ago

Caught another missing string. Power Menu -> 'R' button to Reboot -> message "Rebooting". Message is not translated. Since this is a message, I can't take a screenshot of it. It will be screenshotless. so string from dictionary.txt is: Rebooting=

MayanKoyote commented 11 months ago

Next will be the 'Autostart - Run last app on restart' feature. When you enable this feature, you get this dialog after a reboot: IMG_AST1

so strings from dictionary.txt are: Continue with the AutoStart selected app?= Remove this dialog!=

Apaczer commented 11 months ago

Updated FontHelper, still not ideal but there shouldn't be now weird text wrapping. Added missing strings, thanks again!

MayanKoyote commented 11 months ago

I will continue with the "viewers".

The window that appears when launching files with the .sh extension in Explorer: TERM Terminal=

The skin 'package' installation window that appears when Explorer processes a file with a names like gmenu2x-skin-xxx.zip or gmenunx-skin-xxx.zip: THMI Skin installer= Installing skin=

The window title that appears when deleting a previously installed .ipk package (not just a shortcut): IPKU Uninstall package=

And the strings that are common to these/such windows: Running.. Please wait..= Done=

Probably quite a few strings (~9 strings) regarding the processing of .opk packages could also fit here. But since the Explorer does not want to process .opk packages (yet), it is too early to translate them (yet).

Apaczer commented 11 months ago

The apps are not a part of GMenu2X build (exceptions are cores, emus, games sections translation), so I've wanted to keep them separate. I've plans to embend them in current code as ActionLink (see for e.g. Explorer) that way these links will be part of gmenu2x binary itself. For some sanity, I've changed Terminal app name to Simple Terminal (in apps section) as it more accurently descripte it and doesn't collide with gmenu2x's terminal naming.

Fixed "iconDescription" translating with: https://github.com/MiyooCFW/gmenu2x/commit/aa398ec6e5d2ae33d24653a35d0de9c8ce0d446a Tks for noticing!

Instead of impossing "Done" string over text output, now it just displays msgbox with "Done processing." :pray:

MayanKoyote commented 10 months ago

I compared the files dictionary.txt and translate.txt, removed matches and looked at the conditions for the appearance of the remaining string. And managed to identify another (and perhaps the last one) translatable but previously unnoticed string: Selector Path= The window containing it can be called through the shortcut settings: Edit link -> File Selector -> press 'A'. selpath


The rest strings either relate to other non-Miyoo platforms (like TARGET_GP2X/WIZ/CAANOO or gp2x.h/retrofw.h), or to cases when flags that are not used for Miyoo compilation are defined (HW_EXT_SD/HW_GAMMA/HW_SCALER/HW_TVOUT/HW_UDC/NO_REBOOT/OPK_SUPPORT). Also there are 2 cases, the conditions for the possibility of appearing on the screen I could not understand/find: https://github.com/MiyooCFW/gmenu2x/blob/e22ca905b31193c003a4da04968d604cc2d045a1/src/wallpaperdialog.cpp#L87C3-L92C4 https://github.com/MiyooCFW/gmenu2x/blob/ccfa8a68ee1be24d91b76647ccf27c8c13def77f/src/gmenu2x.cpp#L1631C1-L1637C3


So considering all this, it is quite possible that this is all for now.

Apaczer commented 10 months ago

Good findings, I spent some time to strip whole code of unnecessary code blocks and grabed all tr[".."] occurences. This make final translate.txt for MiyooCFW with: https://github.com/MiyooCFW/gmenu2x/commit/33d9fddbb7e571b36761c5e9bd9b2c381af49866 Most of new findings are unused in real scanario like you mentioned for .e.g