implement Clone for Client

Miyoshi-Ryota / async-ssh2-tokio

asynchronous and easy-to-use high level ssh client library for rust

Apache License 2.0

71 stars 27 forks source link

implement Clone for Client #42

Closed cybersoulK closed 1 year ago

cybersoulK commented 1 year ago

Shouldn't client be Clonable? Since we can create multiple copies and run execute independently from each other? from what i can see, russh creates independent channels, and it seems safe to implement Arc over the Handle.

Since this library is high level, It's better to have it Clonable, rather than implementing Arc over all of the async_ssh2_tokio::Client. how do you think?

Miyoshi-Ryota commented 1 year ago

@cybersoulK I have already published🚀 your work as 0.8.0 to crates.io!