search

Mk555 / pagerduty-tui

Minimalistic terminal UI to manage triggered incidents
GNU Affero General Public License v3.0
4 stars 0 forks source link

Support MacOS/Windows #11

Closed Mk555 closed 3 months ago

Mk555 commented 4 months ago

I was not able to test on MacOS/Windows, if anyone can help and post the issues below it would be helpful !

Mk555 commented 4 months ago

Validated on Windows !

ChristianWitts commented 3 months ago

Just built this for macOS arm64. TUI launches, refreshes just fine. I don't have an unacknowledged incident to test the ACK currently.

does not open a browser to the incident, and busy checking the code to look for a fix to submit a PR.
Mk555 commented 3 months ago

Thanks for your tests !

I think you need to adapt this function to work on MacOS : https://github.com/Mk555/pagerduty-tui/blob/main/src/utils.rs#L14-L17

If you send me a command to open the default browser on MacOS I can add the OS check and add the command

ChristianWitts commented 3 months ago

On macOS you can use /usr/bin/open which will open in the default browser.

I also noticed you should allow configuration for the PagerDuty organization here https://github.com/Mk555/pagerduty-tui/blob/main/src/pagerduty.rs#L15 via the configuration file and config struct.

Mk555 commented 3 months ago

I created a branch for the issue of organization : https://github.com/Mk555/pagerduty-tui/tree/11-support-macoswindows

I will test that tomorrow, but you can add the parameter pagerduty_domain in you config with the name of your organization

Mk555 commented 3 months ago

I also added the open command for macOS, let me know how it works !

ChristianWitts commented 3 months ago

Confirmed that open in browser now works on macOS 👍🏻