This PR fixes a bug in the ci test 12 in ParMmg when compile without SCOTCH library (Point 1). This PR also fixes some minor typos/style inconsistencies (Points 2-5) and factorizes some part of the code (Point 6).
In src/mmg3d/split_3d.c:
Move MMG3D_split*_cfg function before creation of new tetra MMG3D_crea_NewTetra. This fixes the bug in ci test 12 of ParMmg.
Rename MMG3D_configSplit5 by MMG3D_split5_cfg for name consistency with the other MMG3D_split*_cfg functions.
Remove return; at the end of function MMG3D_split1_cfg, MMG3D_split3op_cfg and MMG3D_update_qual as they are defined as void and the return; is at the end of the function and does nothing (and for consistency with the other MMG3D_split*_cfg functions).
Initialized taued as NULL in all functions.
Improve some comments.
In MMG3D_split3cone_sim uses now directly the function MMG3D_split3cone_cfg.
Algiane
commented
1 year ago
This PR fixes a bug in the ci test 12 in ParMmg when compile without SCOTCH library (Point 1). This PR also fixes some minor typos/style inconsistencies (Points 2-5) and factorizes some part of the code (Point 6).
In
src/mmg3d/split_3d.c:MMG3D_split*_cfgfunction before creation of new tetraMMG3D_crea_NewTetra. This fixes the bug in ci test 12 of ParMmg.MMG3D_configSplit5byMMG3D_split5_cfgfor name consistency with the otherMMG3D_split*_cfgfunctions.return;at the end of functionMMG3D_split1_cfg,MMG3D_split3op_cfgandMMG3D_update_qualas they are defined asvoidand thereturn;is at the end of the function and does nothing (and for consistency with the otherMMG3D_split*_cfgfunctions).tauedasNULLin all functions.MMG3D_split3cone_simuses now directly the functionMMG3D_split3cone_cfg.