Closed jcortial-safran closed 7 months ago
All modified and coverable lines are covered by tests :white_check_mark:
:exclamation: No coverage uploaded for pull request base (
master@bae2c83
). Click here to learn what that means.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The change had the unfortunate side-effect to make the CMake configuration fail whenever either SCOTCH or VTK are absent, even if these packages were not used when building Mmg. So it is a significant regression compared to the previous state.
Sorry for that, I should have tested more throughly. I will submit a fix as a new PR.
Thanks for the feedback.
I haven't particularly tested the PR as the integration tests didn't fail but the config files generated by CMake are not tested 😅 .
Use
find_dependency
instead offind_package
in installed CMake config to correctly propagateQUIET
andREQUIRED
flags to users.