MmgTools / mmg

open source software for bidimensional and tridimensional remeshing
http://www.mmgtools.org
Other
362 stars 117 forks source link

Feature/required vertices preservation #273

Closed Algiane closed 4 months ago

Algiane commented 4 months ago

The xreg option (regularization of the position of boundary vertices) was not preserving required vertices. The current PR:

  1. adds a continuous intgration test that test the preservation of an input vertex (in cmake/testing/code/req-vert-3d.c)
  2. adds the check of required vertices in the xreq option.
codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 51.26%. Comparing base (96eab63) to head (662302f). Report is 4 commits behind head on develop.

Files Patch % Lines
cmake/testing/code/req-vert-3d.c 0.00% 12 Missing :warning:
cmake/testing/code/req-vert-s.c 0.00% 12 Missing :warning:
src/mmg3d/analys_3d.c 0.00% 0 Missing and 2 partials :warning:
src/mmgs/analys_s.c 0.00% 0 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #273 +/- ## =========================================== + Coverage 50.47% 51.26% +0.78% =========================================== Files 174 176 +2 Lines 47158 49124 +1966 Branches 10255 11449 +1194 =========================================== + Hits 23802 25181 +1379 - Misses 15633 15934 +301 - Partials 7723 8009 +286 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.