Closed laetitia-m closed 4 months ago
Attention: Patch coverage is 20.00000%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 50.45%. Comparing base (
9e391f3
) to head (3bcfeaa
). Report is 16 commits behind head on develop.
Files | Patch % | Lines |
---|---|---|
src/mmg3d/hash_3d.c | 20.00% | 2 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks!
This PR
Explanations of 1. A bug was introduced by PR #239: triangles required by the user in the input mesh were not preserved anymore.
Indeed, in PR #239, if the face was not
MG_PARALLEL
, then the tagsMG_REQ+MG_SURF
were removed, while onlyMG_SURF
should have been removed if the triangle was initially required by the user.Now, i.e. in this PR, the tag
MG_REQ
of edges is removed only if the edge isMG_PARALLEL
andMG_SURF
. By convention in ParMmg (see tag_pmmg.c in ParMmg), if an entity isMG_PARBDY+MG_NOSURF+MG_REQ
;MG_PARBDY+MG_REQ
;so we remove the tags
MG_NOSURF
andMG_REQ
only if the edge is effectivelyMG_PARALLEL
and identified asMG_NOSURF
.