search

Mmodarre / pyfujitsu_for_homeassistant

MIT License
31 stars 33 forks source link

ClimateDevice is deprecated, modify FujitsuClimate to extend ClimateEntity #16

Closed vicfalls closed 4 years ago

vicfalls commented 4 years ago

since I updated HASS.io to 0.110.x, I get following warning. I've seen it on other repositories and I guess the code needs to be adjusted.

Logger: homeassistant.components.climate Source: components/climate/init.py:547 Integration: Climate (documentation, issues) First occurred: 12:48:39 (1 occurrences) Last logged: 12:48:39

Thanks Vic

pilot1981 commented 4 years ago

I think @Mmodarre must fix the code, otherwise in the 0.111 release we can't use it...

meichthys commented 4 years ago

This project hasn't been updated in over a year, we may need someone to fork it to move it forward. I know @xerxes87 has created patches for this project in the past. @xerxes87, would you be willing to fork this project so we can at least merge some pull requests and move the project forward - at least until @Mmodarre returns?

Mmodarre commented 4 years ago

Sorry guys I have recently become a dad and that changed my availability and spare time left to do cool things. More than happy for others to make changes and merge back.

meichthys commented 4 years ago

@Mmodarre Congrats! I'd be willing to help out too, but I'll be a dad soon too, so i don't foresee much spare time in my future ;) @Mmodarre do you think you'll have time to check for pull requests, or should we fork and merge back in at a later point?

vicfalls commented 4 years ago

Has someone tested the current version with HASSIO 0.112 already? Thanks for sharing your experience.

chiefcomm commented 4 years ago

Has someone tested the current version with HASSIO 0.112 already? Thanks for sharing your experience.

Yes I've had no issues since moving to 0.112.x or none that I've noticed - A/C is working perfectly.

meichthys commented 4 years ago

Looks like v0.113.x may cause issues: image

pilot1981 commented 4 years ago

0.113 need to change code from ClimateDevice to ClimateEntity...

chiefcomm commented 4 years ago

0.113 need to change code from ClimateDevice to ClimateEntity...

@pilot1981 it's not so easy, I have been running a version of code revised by xerxes87 that was changed already to use ClimateEntity - that was working up until I upgraded to 0.113.0 today I have rolled back to 0.112.4

vicfalls commented 4 years ago

for further details take a look at issue #18