search

MnogoByte / django-permanent

Yet another approach to creation of non-deletable and non-removable from db restorable django models.
71 stars 20 forks source link

New release is broken for new installs #47

Closed aidanlister closed 8 years ago

aidanlister commented 8 years ago

See commit 11d236867971df1de69981c6025eab728f8fc848 which I don't think is valid.

generalov commented 8 years ago

Perhaps there is a fix https://github.com/bor3ham/django-permanent/commit/08456f42c7721b44cd41b0b1b8d6494e1257d705 . Don't try to import the django package in the setup.py because that package may not be installed yet. It is not a good idea to check django version in the installation process. The django can be upgraded after django-permanent installation. It's better to describe the exact configuration with package versions externally (in the requirements.txt, .travis.yml, and etc.), then check conditions during app initialization.

meteozond commented 8 years ago

Got it, going to fix it soon

meteozond commented 8 years ago

fixed by #48