Mnsd05 / pe

0 stars 0 forks source link

Wrong error message for big number input for edit-task command #9

Open Mnsd05 opened 1 year ago

Mnsd05 commented 1 year ago

When I give a very big number for both negative and positive, I would expect the program gives me an error like your number is too big or the limit for number is (some number).

image.png

nus-pe-bot commented 1 year ago

Team's Response

Buggy behaviour is caused by extreme user behaviour.

Incorrect error message is shown due to integer overflow. Correct error message will be shown with valid values for type int.

Similar to Issue #2620.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Input big number for add-stat value

When I give a very big number, both negative and positive, the program tells me to give an integer although the value is already an integer

image.png


[original: nus-cs2113-AY2223S2/pe-interim#2449] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Buggy program behaviour is caused by extreme user behaviour.

Bug is caused by integer overflow. Values between -2,147,483,648 and 2,147,483,647 (min and max values of type int) will result in expected behaviour.

Valid negative values and zero throws the following error:

ERROR: Integer provided should be above 0

Valid non-zero positive values will successfully update the stat.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** The severity should be very low but it should not be rejected as this minor bug makes the program incomplete