MoArtis / RCGMod

UserXpMod is a "quality of life" mod for River City Girls by Wayforward.
42 stars 2 forks source link

Exclamation mark with no k.o. hit (damage display bug?) #30

Closed Alua7 closed 4 years ago

Alua7 commented 4 years ago

I hit a tiger("King") with an yoyo (Misako) and it displayed 36! But no k.o. Bombic bra is on but hit did not a knockout. UPD: hmm unlike other weapons yoyo seems not to actually crit. So maybe game's bug Also: yoyo gives ! but not crit, other weapons give crit but no "!". btw funny bombic bra also affects cars

MoArtis commented 4 years ago

Seems to be working fine with the weapon I tried so far. image And yeah Bomb bra affects anything that can damage with a direct hit. (notice that Bomb bra doesn't work when throwing enemies and weapons.) I'm on my way to test the yoyo.

MoArtis commented 4 years ago

image Same for the yoyo. I will leave it like that for now. We will see if the bug is still reproducible with the 1.3. But to be clear I changed nothing in the code about that. At least for now. 😁

Alua7 commented 4 years ago

https://youtu.be/jA43RozSMlA?t=15s Pls start from 0:15. 1 episode - ! opp dies (but I swear it's not crit) 2 episode - ! opp doesn't die 3 episode - crit with no ! 4 episode - one more ! I got ! on various situations - 1st hit, 5th hit but no k.o. Maybe troubles of old version tho)

MoArtis commented 4 years ago

I think I found the root cause of the issue. Not sure why I did it that way back then but It seemed consistent without modifying RCG's code. But reading the code again, it seems wrong. I changed the code to ensure more consistent results. A test with a 60% chance of triggering the effect seems conclusive: image The fix will be part of the version 1.3.

Alua7 commented 4 years ago

it seems like it working fine now