Ribbon Bra hint - Githubissues

MoArtis / RCGMod

UserXpMod is a "quality of life" mod for River City Girls by Wayforward.

42 stars 2 forks source link

Ribbon Bra hint #33

Closed Alua7 closed 4 years ago

Alua7 commented 4 years ago

It seems like Ribbon Bra still not matching its description. Can its hint be changed to actual "100% (not 10%) chance to get 2 items from vending machines and crates". Hope this item they will not fix :1st_place_medal:

MoArtis commented 4 years ago

Let me check the code. That sounds easy to check.

MoArtis commented 4 years ago

Apparently they are testing for the wrong effect. And they just test if it is equipped or not. 🤔

MoArtis commented 4 years ago

Apparently it is a misconfiguration issue after they changed the EquipEffect enum. The item is also using that reflect1Damage thing. And again it never test for a chance to apply the effect so it is always in effect. I will just override the translation using the mod's data to say 100% instead of 10%.

MoArtis commented 4 years ago

Alua7 commented 4 years ago

And special thanks for adding json support so I could fix some localization's errors for my language <3