search

MoArtis / RCGMod

UserXpMod is a "quality of life" mod for River City Girls by Wayforward.
42 stars 2 forks source link

Bug that might be related to shared rewards #34

Closed Gekasx closed 4 years ago

Gekasx commented 4 years ago

I was testing v1.3 and the second i died my money went from 80 to 9999 (i got the achievement of collecting $5000) and after that my money looks like this money

Alua7 commented 4 years ago

Numbers summed not as numbers? :P Forgive me if I'm getting wrong, but aren't any unlocked(available) characters get items, money and XP for missions? Or feature is intended to disable it?

MoArtis commented 4 years ago

@Gekasx So you activated shared rewards? I need to test that. @Alua7 NaN could be displayed if the number is infinity or is the result of a division by 0 in runtime (iirc Unity doesn't crash at all in that case).

MoArtis commented 4 years ago

@Gekasx Can you give me more context? What else did you changed? Were you playing alone or with another player?

MoArtis commented 4 years ago

Can't reproduce with a clean install and using Rikki in solo while getting defeated by the first boss. image I need to try in coop. it is certainly related to shared rewards.

MoArtis commented 4 years ago

image 🤔 Strange... I'm gonna check the code directly.

MoArtis commented 4 years ago

@Gekasx I changed the shared rewards feature to avoid potential division by 0. I can't be 100% sure that was the source of your issue but I'm pretty sure. Give it a try by re-downloading the pack again (It's updated) and let me know. https://github.com/MoArtis/RCGMod/releases/tag/1.3

Gekasx commented 4 years ago

i tried to replicate the bug with no succes (with the previous version and the new one) i guess it was a super specific situation because the only factor that actually matters was me playing alone after misako's death

MoArtis commented 4 years ago

Thank you! I think it should be fine now. I'm gonna close that issue for now.