MoDeNa-EUProject / MoDeNa

Software Framework for MOdelling of morphology DEvelopment of micro- and NAnostructures (MoDeNa)
17 stars 19 forks source link

Addressing issue #4 #15

Closed sigveka closed 9 years ago

sigveka commented 9 years ago

Implementing strategy InitialData for initialising a surrogate model using input/output relation known a-priori, e.g. from experimental data.

henrus commented 9 years ago

Hi Sigve, in examples/idealGas:

1) I had difficulties to understand why the same function is there twice. Ok, one is autogenerated. A comment would help! 2) Is is necessary to make m2 a BackwardMappingModel? 3) p=1,2,3Pa is a little unrealistic.

Henrik

sigveka commented 9 years ago
  1. Noted, will clean up the example (I believe there are unnecessary imports as well)
  2. No, just demonstrating that we are not limited to "Forward Mapping Model"
  3. Yes; as is a gas with no volume

On 11 September 2015 at 11:18, Henrik Rusche notifications@github.com wrote:

Hi Sigve, in examples/idealGas:

1) I had difficulties to understand why the same function is there twice. Ok, one is autogenerated. A comment would help! 2) Is is necessary to make m2 a BackwardMappingModel? 3) p=1,2,3Pa is a little unrealistic.

Henrik

— Reply to this email directly or view it on GitHub https://github.com/MoDeNa-EUProject/MoDeNa/pull/15#issuecomment-139496498 .