search

MoDeNa-EUProject / MoDeNa

Software Framework for MOdelling of morphology DEvelopment of micro- and NAnostructures (MoDeNa)
17 stars 19 forks source link

Fixed initialisation of substitute models in ForwardMappingModel #85

Closed sigveka closed 8 years ago

sigveka commented 8 years ago

I think this fix ("elif" statement in line 188 in Strategy.py) is a temporary one.

The problem is a flaw in ModenaFireTask, run_task (line 980), where if 'point' in self will never be True for a ForwardMappingModel. Consequently, only the substitute models in for BackwardMappingModel s will be checked and instantiated.

henrus commented 8 years ago

Hi Sigve, Hi Christos,

merged.

@Christos: Does this fix your problem?

Henrik

On 24/03/16 23:24, Sigve Karolius wrote:

I think this fix ("elif" statement in line 188 in Strategy.py) is a temporary one.

The problem is a flaw in ModenaFireTask, |run_task| (line 980), where |if 'point' in self| will never be |True| for a /ForwardMappingModel/. Consequently, only the substitute models in for _BackwardMappingModel_s will be checked and instantiated.

    You can view, comment on, or merge this pull request online at:

https://github.com/MoDeNa-EUProject/MoDeNa/pull/85

    Commit Summary

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/MoDeNa-EUProject/MoDeNa/pull/85

Dr. Henrik Rusche WIKKI Ltd. Unit 459 Southbank House Tel: +44 (0)20 3176 7190 Black Prince Road E-mail: h.rusche@wikki.co.uk

London SE1 7SJ, United Kingdom

www.wikki.co.uk