search

MoJo2600 / pihole-kubernetes

PiHole on kubernetes
506 stars 178 forks source link

chart.yaml appVersion and image.tag diverge #152

Closed morremeyer closed 3 years ago

morremeyer commented 3 years ago

I just noticed that the appVersion in Chart.yaml and the image.tag in values.yaml have diverged.

As appVersion is optional, I’d go with removing it altogether and updating image.tag only in the future.

The other variant would be to default the pihole container in the Deployment to {{ .Chart.appVersion }} and unset image.tag.

@MoJo2600, which one do you prefer? I’d open a pull request for any of the two.

MoJo2600 commented 3 years ago

I think removing the optional appVersion is a good approach. I'd be very happy if you would create a pull request for this.