search

MoJo2600 / pihole-kubernetes

PiHole on kubernetes
506 stars 178 forks source link

Feat/configure dhcp #155

Closed morremeyer closed 3 years ago

morremeyer commented 3 years ago

This splits the DHCP service into its own service resource and moves the configuration to serviceDhcp.

This is a breaking change for configurations that do not run the serviceDns default values.

This PR already includes the changes from #153 and should be merged after #153.

MoJo2600 commented 3 years ago

Hello, sorry for the delay. Would you please rebase your commit to the latest master. I will merge your change afterwards.

morremeyer commented 3 years ago

@MoJo2600 No worries! Branch is rebased now.

MoJo2600 commented 3 years ago

I will merge this now. Please stay with me to help resolve any issues that may arise for the users during upgrade :)

morremeyer commented 3 years ago

Please stay with me to help resolve any issues that may arise for the users during upgrade :)

Of course! Just mention me in any issues if needed.