MoJo2600 / pihole-kubernetes

PiHole on kubernetes
499 stars 173 forks source link

Missing template values #164

Closed Rossco88 closed 3 years ago

Rossco88 commented 3 years ago

Hi Guys Sorry I am new to Helm, but wondering if there is possibly some missing template variables from the service templates.

With the following config in my values file, I get the below error

serviceDns: type: LoadBalancer port: 53 externalTrafficPolicy: Cluster loadBalancerIP: "My IP Went Here"

a fixed LoadBalancer IP

annotations: {}

metallb.universe.tf/address-pool: network-services

metallb.universe.tf/allow-shared-ip: pihole-svc

ERROR=Error: failed to parse pihole.values.yml: error converting YAML to JSON: yaml: line 27: did not find expected key

and noticed in the template files there is no value for the metallb annotations

{{- if or (eq .Values.serviceDns.type "NodePort") (eq .Values.serviceDns.type "LoadBalancer") }} externalTrafficPolicy: {{ .Values.serviceDns.externalTrafficPolicy }} {{- end }}

Thanks for taking a look

Rossco88 commented 3 years ago

Nevermind, I see what I did wrong here. I hadn't enclosed the annotations with the braces