MoJo2600 / pihole-kubernetes

PiHole on kubernetes
506 stars 178 forks source link

No way to customize cnames #171

Closed larivierec closed 3 years ago

larivierec commented 3 years ago

As it seems, the 05-pihole-custom-cname.conf is loaded inside the pods.

name@cluster:~/k8s/pihole$ kc exec pod/pihole-778b575967-wtvmv -c pihole -n pihole -- ls /etc/dnsmasq.d/
01-pihole.conf
02-custom.conf
05-pihole-custom-cname.conf

I was wondering if this feature was planned. CNAME records are helpful by not having to duplicate each A record having the same IP Address (i'm guessing this is the current work around).

02-custom.conf seems to be handled. https://github.com/MoJo2600/pihole-kubernetes/blob/master/classic/deployment-pihole.yml#L59

larivierec commented 3 years ago

confirmed working after helm upgrade with a list of cnames in PR #174