Misc non-critical fixes

consideRatio commented 3 years ago

Hi @MoJo2600, thanks for making this Helm chart so I don't have to! :D

I found some small fixes while inspecting the Helm chart that I submit in this PR as four separate commits.

Update .helmignore to not package unused files
Restart on change to ftl configmap
Fix documentation typo
Fix formatting bug for monitoring.podMonitor.labels

Not part of this PR as I wasn't confident about it, but I would think that the /docs folder and the /example folder should be deleted from the repo at this point in time.

I was also very confused about this reference, I think these lines can be deleted but they may be used by the later referenced action but I don't think they are.

https://github.com/MoJo2600/pihole-kubernetes/blob/f04bdbf3818701435dba0e2619ddfac5e91303d8/.github/workflows/release.yaml#L29-L32

MoJo2600 commented 3 years ago

Thank you very much. This change will definitely improve the chart! Only thing is, that you will have to bump the chart version.

MoJo2600 commented 3 years ago

LGTM! Thank you!

MoJo2600 / pihole-kubernetes

Misc non-critical fixes #176