search

MoJo2600 / pihole-kubernetes

PiHole on kubernetes
498 stars 173 forks source link

[Feature Request] #204

Open darkcloud784 opened 2 years ago

darkcloud784 commented 2 years ago

Add Unbound.

https://docs.pi-hole.net/guides/dns/unbound/

MoJo2600 commented 2 years ago

Oh yeah, that is something that I'd like to have, too.

moritz31 commented 2 years ago

Shouldn't be an pihole thing. Just deploy unbound and then set the unbound instance as an dns server

darkcloud784 commented 2 years ago

Shouldn't be an pihole thing. Just deploy unbound and then set the unbound instance as an dns server

Why have 2 containers when you can have 1, and make the unbound server optional.

MoJo2600 commented 2 years ago

It would be nice to have an easy way to set up both at once, but I see @moritz31 point as well. This is the pihole chart and it should be only for pihole. Maybe we could add a sample or some scripts to setup both in an easy way?

darkcloud784 commented 2 years ago

It would be nice to have an easy way to set up both at once, but I see @moritz31 point as well. This is the pihole chart and it should be only for pihole. Maybe we could add a sample or some scripts to setup both in an easy way?

This is what I was referring to, an easy way you can enable a script run on deployment that installs unbound or something in the same container rather than having 2 containers being separate.

moritz31 commented 2 years ago

@darkcloud784 imho it is wrong to put these two applications into one container. I try to create a simple helmchart for unbound so one can simply deploy unbound, and the pihole helmchart should be already configureable for this

MoJo2600 commented 2 years ago

I'd suppose to create a tutorial on how to combine pihole with your unbound chart. We could add this to the documentation of both charts?

darkcloud784 commented 2 years ago

@darkcloud784 imho it is wrong to put these two applications into one container. I try to create a simple helmchart for unbound so one can simply deploy unbound, and the pihole helmchart should be already configureable for this

Why not at least give the user the option to do so or not? Its not like it causes errors or causes your server to explode or anything. Its an option.

mlhynfield commented 3 months ago

Is there any particular reason why unbound couldn't be added in a similar manner to the existing cloudflared DOH implementation? I can get it working as a sidecar with the extraContainers field just fine as far as I can tell