search

MoJo2600 / pihole-kubernetes

PiHole on kubernetes
498 stars 173 forks source link

fix: Using env vars instead of configmap for ftlconf #205

Closed Blamas closed 2 years ago

Blamas commented 2 years ago

Hello,

I was having issues with the configmap for the ftl configuration. When the init script for the pihole container was trying to modify '/etc/pihole/pihole-FTL.conf' I was getting Device or resource busy errors. It might be related to issues with the modification of the configmap and nested mountPoints

So after a little bit of digging I noticed that it's now possible since the 2021.11 pihole container release to use environment variables to configure FTLDNS.

Therefore, I suggest to bump the appVersion, remove the dedicated configmap and use those environment variables instead. It does not breaks either the compatibility with previous values.yaml.

MoJo2600 commented 2 years ago

Thank you! I like this change. Could you please merge your change with the current dev branch and bump the version? I merged a commit which I should have merged after your PR -.-

Blamas commented 2 years ago

All done !

MoJo2600 commented 2 years ago

LGTM! Thank you again!