search

MoJo2600 / pihole-kubernetes

PiHole on kubernetes
498 stars 173 forks source link

Removal: drop deprecated `spec.loadBalancerIP` #216

Open DerRockWolf opened 2 years ago

DerRockWolf commented 2 years ago

spec.loadBalancerIP is deprecated since v1.24 in favor of provider specific annotations (such as metallb.universe.tf/loadBalancerIPs for MetalLB)

The.spec.loadBalancerIP field for a Service was deprecated in Kubernetes v1.24.

This field was under-specified and its meaning varies across implementations. It also cannot support dual-stack networking. > This field may be removed in a future API version.

Docs: https://kubernetes.io/docs/concepts/services-networking/service/#loadbalancer

PR: https://github.com/kubernetes/kubernetes/pull/107235

Fell free to adjust the version if you don't want major bumps for values removal.

FYI: You should somehow enforce the generation of the chart readme (charts/pihole/README.md), as it was missing some previously added values!

DerRockWolf commented 9 months ago

After more than one and a half years I've stumbled upon my draft PR :joy:

MoJo2600 commented 9 months ago

Hey, thank you again for your work. I'm working on a V2 of this chart in a private repo right now. Mainly I want to change the deployment and have some pipeline to release new pihole versions automatically. I'd love to merge the outstanding pull requests when this is finished and release a v2 of this chart asap.

MoJo2600 commented 7 months ago

I merged the new deployment stuff right now. I do want to start working on V3 now. There is a branch next where we can merge all the breaking changes.