search

MoJo2600 / pihole-kubernetes

PiHole on kubernetes
498 stars 173 forks source link

[Feature Request] serviceAccountName and metadata annotations for deployment #219

Open alteredtech opened 2 years ago

alteredtech commented 2 years ago

Trying to integrate pihole with hashicorp vault. From what I can tell is that it requires spec.template.metadata.annotations and spec.template.spec.serviceAccountName to be entered. I could try to do it myself but I am still very new to this.

This is the hashicorp guide I am following.

Apollorion commented 2 years ago

Trying to integrate pihole with hashicorp vault. From what I can tell is that it requires spec.template.metadata.annotations and spec.template.spec.serviceAccountName to be entered. I could try to do it myself but I am still very new to this.

This is the hashicorp guide I am following.

You can add pod annotation with podAnnotations in your values files. This helm chart doesn't support specifying a service account, you'd probably have to open a PR to support that. But, if I remember correctly, every pod gets the default service account automatically. So you could use that for whatever you need.