search

MoJo2600 / pihole-kubernetes

PiHole on kubernetes
498 stars 173 forks source link

Allow custom port/scheme to be used in probes #229

Closed fernferret closed 2 years ago

fernferret commented 2 years ago

This enables the probes to use https probes for lighttpd configurations that only support https.

I'm using a custom lighttpd config that forces https based on CertManager issued certificates. Because of this, the probes fail if they use the http endpoint. This is a backward compatible implementation that allows people to specify custom ports/schemes for the probes, in my case:

probes:
  liveness:
    port: https
    scheme: HTTPS
  readiness:
    port: https
    scheme: HTTPS
MoJo2600 commented 2 years ago

LGTM! thank you for your contribution!