search

MoJo2600 / pihole-kubernetes

PiHole on kubernetes
498 stars 173 forks source link

Why use crazymax cloudflared repo when cloudflare maintains their own? #247

Open Johbii opened 1 year ago

Johbii commented 1 year ago

Title. Default value is to use the user maintained repo when it is much more reliable to use the official repo.

While there is configuration for changing the repo, there is no configuration for changing container arguments as is necessary for the official docker container to work.

tupperward commented 1 year ago

According to the cloudflare/cloudflared documentation, you set the configuration using a configuration.yaml file.

We should be able to do this by creating a ConfigMap with our configuration.yaml data and set it to a volumeMount in the container at the default install path.

We can likely do this with just a short _helper.tpl settings to create this configmap and then mount the data to a volume at the config path only if there is a value that's set. Since Helm evaluates empty strings as Null we should be good there.

I think I can make a branch for this.

magsol commented 2 months ago

Was there any update on this? I've been having a lot of issues with the crazymax container crashing for no discernible reason over the past week and would love to try something more reliable (or just something else). It's making pihole almost unusable in its entirety.