search

MoJo2600 / pihole-kubernetes

PiHole on kubernetes
493 stars 171 forks source link

Add the ability to add extra containers to the Pihole pod #260

Closed kenlasko closed 1 year ago

kenlasko commented 1 year ago

I have a container that I use to run a process to monitor the Pihole logs for specific DNS queries. The container uses a shared volume created on /var/log/pihole. I currently cannot use this Helm chart because there is no way to add my own container.

This pull request simply adds the ability to add any number of containers via values.yaml.

It passes LINT and I was able to successfully run my fork of the Helm chart to get my secondary container running within the Pihole pod.

This is my first ever contribution to any Github project. Please be gentle, but feedback is appreciated. :)

MoJo2600 commented 1 year ago

Sorry, I merged another PR before yours. Thank you for your contribution, it looks good to me.

kenlasko commented 1 year ago

No worries. I bumped the version up another notch. Hope I'm doing this right.

MoJo2600 commented 1 year ago

Ha, now I screwed up the merge by adding trailing whitespaces :) Don't ask me if you doning it right when I can't do it right in the first place ;)