feat: add ability to disable admin password

MoJo2600 / pihole-kubernetes

PiHole on kubernetes

493 stars 171 forks source link

feat: add ability to disable admin password #274

Closed giolekva closed 6 months ago

giolekva commented 7 months ago

Adds option admin.enabled (default true) which if set to false disables admin password.

Closes: #251

Follows similar approach to taken by PR #261 but does not create secret if admin password is disabled.

From my understanding suggestion made on PR #261 will not work as there is no way to distinguish value not set and value set to empty string in golang/helm templates. Hence why additional admin.enabled or disablePassword field is required.

GeeWizWow commented 6 months ago

Bump, would love to see this feature land. @MoJo2600 Any chance of a review?

MoJo2600 commented 6 months ago

Hey, I was working on another PR yesterday. I hope i get it managed this weekend :)

MoJo2600 commented 6 months ago

A little later than expected, but your change LGTM. I only updated the readme file. Will merge now.