MoJo2600 / pihole-kubernetes

PiHole on kubernetes
493 stars 171 forks source link

feat!: Change yaml for Custom DNS definition + add custom.list template #285

Open xorinzor opened 5 months ago

xorinzor commented 5 months ago

Description of the change

Breaking change that will require a migration action from v2 to v3

Changed custom DNS YAML definition from:

dnsmasq.customCnameEntries:
- cname=cname.foo.bar,foo.bar
dnsmasq.customDnsEntries:
- address=/foo.bar/192.168.1.1

to:

dnsmasq.customCnameEntries:
- domain: cname.foo.bar
  target: foo.bar
dnsmasq.customDnsEntries:
- domain: foo.bar
  address: 192.168.1.1

The fields are named to how they're named in the GUI.

I've moved the formatting of these lines to the configmap templates. Additionally, I added a new configmap to generate the custom.list so the custom DNS entries show up in the GUI.

Benefits

Custom DNS entries will show up in GUI, with the additional benefit of a better readable values.yaml

Possible drawbacks

Will require users to edit their values.yaml when upgrading from v2 to v3

Applicable issues

Checklist

MoJo2600 commented 4 months ago

Thank you for your contribution. I like this change even if it is breaking the release. I will test it on my installation. There is another breaking change in the pipeline then I'll create one new release with both changes.