The pihole-web service is now valid when both serviceWeb.http and serviceWeb.https are disabled. Without this change, setting both of these to false will result in an invalid service manifest with an empty spec.ports value.
Description of the change
This change prevents the creation of the web service manifest if both serviceWeb.http.enabled and serviceWeb.https.enabled are false. Setting either of these values to true (the default) will preserve existing behaviour.
Benefits
Allows the user to not expose the pihole web service by disabling both http and https in the serviceWeb configuration option.
MoJo2600
commented
7 months ago
The
pihole-webservice is now valid when bothserviceWeb.httpandserviceWeb.httpsare disabled. Without this change, setting both of these to false will result in an invalid service manifest with an emptyspec.portsvalue.Description of the change
This change prevents the creation of the web service manifest if both
serviceWeb.http.enabledandserviceWeb.https.enabledarefalse. Setting either of these values to true (the default) will preserve existing behaviour.Benefits
Allows the user to not expose the pihole web service by disabling both http and https in the
serviceWebconfiguration option.Possible drawbacks
Applicable issues
Additional information
Checklist