search

MoOx / pjax

Easily enable fast Ajax navigation on any website (using pushState + xhr)
MIT License
1.45k stars 124 forks source link

Please fix your bundle #193

Closed aolko closed 5 years ago

aolko commented 5 years ago

Your bundle is broken, index(.min).js still reuires scripts from the lib folder, which does not exist. Also getting this error

BehindTheMath commented 5 years ago

Did you read the README? You should be using pjax.js or pjax.min.js.

index.js is not a bundle.

fjeddy commented 5 years ago

pjax.jsand pjax.min.js doesnt exist, and the readme doesn't specifically mention it, so it's quite understandable that he gets confused.

BehindTheMath commented 5 years ago

I'm not sure what you mean. The package on npm includes both of those files (see here). The Github repo does not, but I don't see anywhere in the README suggesting you clone the repo.

fjeddy commented 5 years ago

And what about those that don't use NPM? Which is quite a few people, more people that don't use NPM then people that do.

BehindTheMath commented 5 years ago

The README gives clear instructions how to use a script tag with the CDN link, and it says quite clearly to use either pjax.js or pjax.min.js.

fjeddy commented 5 years ago

And yet again, your making assumptions that anyone want's to use a third party cookie collecting CDN. Like I said, I get his confusion, i ditched the entire library myself due to how you do things.

And before you reply: Yes, we all know you can copy the files from CDN. Thats not the point tho.

BehindTheMath commented 5 years ago

The only way I can think of to get the library without using the CDN or npm is by cloning from Github. I'm not sure why you feel the CDN uses cookies and Github does not, or why it's better to copy from Github than the CDN.

Regardless, such an installation method is never mentioned in the README, so it's a bit presumptuous to do it and them complain when it doesn't work. I can add instructions for building from the source, but I think this is the first time someone has mentioned having an issue with this.

fjeddy commented 5 years ago

99% don't mention it, they just move on to the next thing.