search

MoOx / pjax

Easily enable fast Ajax navigation on any website (using pushState + xhr)
MIT License
1.46k stars 125 forks source link

HierarchyRequestError #39

Closed graup closed 8 years ago

graup commented 9 years ago

Hi, I tried using the latest version but it breaks on a HierarchyRequestError. I tracked down the bug:

Here you call trigger(document, ...), but trigger will add the element to the DOM if it doesn't have a parentNode (which document doesn't) here. The result is a call like document.body.appendChild(document) which breaks.

After downgrading to 0.1.4 this error disappeared.

rstacruz commented 9 years ago

getting this too.

Axure commented 9 years ago

Me, too.

MoOx commented 9 years ago

Fix as a PR is always welcome :)

MoOx commented 9 years ago

Note: I don't currently use this package and so, do not want to take time for it.

pklada commented 8 years ago

Did this ever get fixed? Getting this too.

MoOx commented 8 years ago

Closed by 1d292a1a6eeb19918304c28d31b513d05a88c086

rstacruz commented 8 years ago

woohoo!