search

MoOx / pjax

Easily enable fast Ajax navigation on any website (using pushState + xhr)
MIT License
1.46k stars 125 forks source link

Add switchElementsAlt() to the default switches #93

Closed BehindTheMath closed 6 years ago

BehindTheMath commented 6 years ago

Fixes #83.

BehindTheMath commented 6 years ago

@MoOx I can't figure out why testling is erroring. This PR shouldn't affect that.

The affected tests are here.

MoOx commented 6 years ago

@BehindTheMath since you have been added as a collaborator to this repo, you don't need to use your fork anymore and can cut a branch directly from this repo!

MoOx commented 6 years ago

It seems that CI found a regression. Note that testling should be used directly (see note in package.json) if you want to run existing tests

BehindTheMath commented 6 years ago

From the Travis logs, it looks like the regression was caused by #80. However, I don't see anything in that PR either that would cause this error.

Additionally, I ran testling locally in a VM, and it passed with no errors.

So I'm going to take the output of testling with a grain of salt, until it can be switched for an updated testing framework.