Make images customizable (with instructions)

[DjebbZ]

Here you go. Tested successfully in my local Firefox.

[DjebbZ]

See #7

[MoOx]

This is breaking the online version .sample should be force added as images.js

[kud]

Yep.

[DjebbZ]

I didn't know about add --force, hope it will do the trick.

[MoOx]

You can remove the .sample & adjust the README ;)

[DjebbZ]

Yep

[DjebbZ]

If I remove the sample, will people still have the original images.js to play with ?

Yes, but editing images.js is visible by git, even if in .gitignore (I deleted and re-downloaded my fork to test).

[MoOx]

Well done. Thanks !

[MoOx]

Oh.

[MoOx]

Weird.

[DjebbZ]

Indeed.

[DjebbZ]

Maybe, reverting to previous commit, and manually add the really ignored images.js file will do the trick ?

[MoOx]

online version need the file to be versionned (for now). Not sure what is the best way to handle that. Anyway, it's a step. I would like to drop this manual file for the long run (see https://github.com/putaindecode/pretty-new-tab/issues/7#issuecomment-57624906)

[DjebbZ]

Sorry for the weird situation I put you in...

[MoOx]

Not a big deal.

[kud]

The best way would be to have master which compiles to gh-pages and add images.js in it.

[DjebbZ]

Nice idea ! A post-commit hook ?

[kud]

or gulp-gh-pages.

[DjebbZ]

Can I leave this stuff to you guys ?

[kud]

Yesh.

[MoOx]

Yeah we will end up that way: clean decoupled code Here is a issue to discuss about that

https://github.com/putaindecode/pretty-new-tab/issues/23

[DjebbZ]

Thanks ! I need to get back to work (you know, the "real world" :/ :D)