thank you for the recent changes to dl_read_gcp()! I tested the updates locally and found they worked nicely. There is one thing remaining that I think only impacts Windows users. This PR attempts to fix that and also should not impact the way dl_read_gcp() works for non-Windows users.
tldr: system() can throw an error in local R sessions for Windows users when both ignore.stderr and ignore.stdout are TRUE. I made modifications so that users can set one of those inputs to FALSE if they want to, and added documentation explaining the fix.
bcjaeger
commented
1 year ago
Hello,
thank you for the recent changes to
dl_read_gcp()! I tested the updates locally and found they worked nicely. There is one thing remaining that I think only impacts Windows users. This PR attempts to fix that and also should not impact the waydl_read_gcp()works for non-Windows users.tldr:
system()can throw an error in local R sessions for Windows users when bothignore.stderrandignore.stdoutareTRUE. I made modifications so that users can set one of those inputs toFALSEif they want to, and added documentation explaining the fix.