search

MoathOthman / MOLH

Localization helper for iOS apps mainly focusing on the LTR/RTL issue
MIT License
117 stars 36 forks source link

Text Field placeholder direction is not updated first time when we change the language in both rtf and ltr cases. #26

Closed zahidshaikh795 closed 5 years ago

zahidshaikh795 commented 6 years ago

simulator screen shot - iphone x - 2018-09-17 at 14 33 19 simulator screen shot - iphone x - 2018-09-17 at 14 33 14 simulator screen shot - iphone x - 2018-09-17 at 14 31 39 simulator screen shot - iphone x - 2018-09-17 at 14 31 31

Every thing is working fine but the text field placeholder direction is not changing for the first time we change the language.If I relaunch the app then its direction changes to the one I selected before.

MoathOthman commented 5 years ago

hey @zahidshaikh795 I am working on this one , I think I have a solution for it at least , you should though get the alignment correctly when you switch though , you need to set the uitextfield tag to less than zero.

zahidshaikh795 commented 5 years ago

Settting the uitextfield tag to less than zero doesn't affect anything. When I switch the language the ui of textfield doesn't flip. But if I run the project again then its ui is perfectly fine. Why it is not working only in case of text field.

MoathOthman commented 5 years ago

Textfield is different since it is an input control and not just a display so we need to take in consideration the keyboard language . Are you sure you have the latest code, currently, am not sure if the latest release point to the latest in master!!

Sent from my iPhone

On Sep 18, 2018, at 2:26 PM, Zahid Shaikh notifications@github.com<mailto:notifications@github.com> wrote:

Settting the uitextfield tag to less than zero doesn't affect anything. When I switch the language the ui of textfield doesn't flip. But if I run the project again then its ui is perfectly fine. Why it is not working only in case of text field.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/MoathOthman/MOLH/issues/26#issuecomment-422356515, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABHNhxoYBP3whZVDF5ss_lhfFSREt8twks5ucNh3gaJpZM4Wrg_E.

zahidshaikh795 commented 5 years ago

I have installed the pod at least one week ago.It would be really appreciable if you let me know when you update the project.

MoathOthman commented 5 years ago

@zahidshaikh795 I created a PR with a fix for the textfield issue, you may use 26.textfield.issue branch and tell me how it goes with , and then if its alright I will merge it . please try it as soon as possible.

MoathOthman commented 5 years ago

fixed in 0936