MoathOthman / MOLH

Localization helper for iOS apps mainly focusing on the LTR/RTL issue
MIT License
117 stars 36 forks source link

App Getting Crashed for iOS 13 #48

Closed imuhammadjabbar closed 4 years ago

imuhammadjabbar commented 4 years ago

The app is getting crashed on .reset() function. You are using delegate.window there but "window" has been moved to SceneDelegate in iOS 13. UIView.transition(with: ((delegate.window)!)!, duration: 0.5, options: transition, animations: {}) { (f) in }

So, I tried to change it to sceneDelegate.window but it is still getting crashed.

Here is the screenshot for your reference: https://imgur.com/ZuPr4RW

Any workaround for now? Please let me know.

Regards,

MoathOthman commented 4 years ago

@imuhammadjabbar if you are not supporting iPad OS with multiple scenes you can opt-out from using Scene delegate AFAIK.

imuhammadjabbar commented 4 years ago

@imuhammadjabbar if you are not supporting iPad OS with multiple scenes you can opt-out from using Scene delegate AFAIK.

But, I am setting my rootViewController in UISceneDelegate. I had implemented the reset() and MOLHResetable in UISceneDelegate as well. But still getting this crash.

imuhammadjabbar commented 4 years ago

@imuhammadjabbar if you are not supporting iPad OS with multiple scenes you can opt-out from using Scene delegate AFAIK.

Any workaround you can suggest with UISceneDelegate?

MoathOthman commented 4 years ago

check this issue https://github.com/MoathOthman/MOLH/issues/46 , it might help but I have not tried that tbh.

MoathOthman commented 4 years ago

Fixed

islamnabil commented 4 years ago

Hi @MoathOthman , I have the same issue here at iOS 13 ... the app doesn't on iPad OS .. just iPhone

MoathOthman commented 4 years ago

@islamnabil have you check latest version. i made a fix recently for this.

MoathOthman commented 4 years ago

its v1.3 !

MoathOthman commented 4 years ago

that's actually the cocoapods version, you can find the molh version in the Podfile.lock heh.