MoathOthman / MOLH

Localization helper for iOS apps mainly focusing on the LTR/RTL issue
MIT License
117 stars 36 forks source link

after update xcode and swift version #64

Closed YallaDealz closed 3 years ago

YallaDealz commented 3 years ago

after update xcode and swift version most of screen not fit and make some problems in Arabic and English location

are there any next update?

MoathOthman commented 3 years ago

@YallaDealz can you give more details , as to which xcode version and swift version. can you please also reproduce the behavior using the demo project or provide screen shots to show whats wrong.

YallaDealz commented 3 years ago

Xcode 12.2 Swift 5.3

YallaDealz commented 3 years ago

![Uploading 71A0BC94-F832-4678-A3BD-2791B346FF50.jpeg…]()

YallaDealz commented 3 years ago

If i switch between arabic to english its give me this conflict on data

YallaDealz commented 3 years ago

![Uploading 1FD99234-AC21-4107-BEC0-0CD464E0AB11.jpeg…]()

MoathOthman commented 3 years ago

@YallaDealz sorry for the late reply, i can't see the images you uploaded

MoathOthman commented 3 years ago

i will update the xcode though and try

YallaDealz commented 3 years ago

ok, update and check Xcode please also this image link to check if I switch between languages what's happening? https://prntscr.com/vxdx1h

MoathOthman commented 3 years ago

@YallaDealz thank you, i will update xcode tonight and check if i can reproduce the issue.

YallaDealz commented 3 years ago

ok thanks for your fast reply, i will waiting your feedback ASAP.

Thanks

MoathOthman commented 3 years ago

I just tried it ,seems like labels are not correctly flipping the alignment, i will try to fix it soon, but for now this fails on label where you set the left and right constraints, but usually you don't need that, usually just constraining one side would be enough and the label will resize based on its width

YallaDealz commented 3 years ago

ok i wil try to fix from my side this issue but when you publish an update please inform me

thanks

YallaDealz commented 3 years ago

we removed all constrains but still the problem is presist so we noticed if we switched between language this problem is happening but if we closed the app and reopen it again we notice the problem is not found and all text is aligned so the problem now in switching between two languages during the app is running

MoathOthman commented 3 years ago

@YallaDealz actually you should be setting the label tags to less than 0 , try setting the label tags for example -1 or less. this should solve the problem as well, if you don't want the label to flip make it more than 0. you dont need to remove all constraints just from one side e.g. if label is located on the left size constraint top and left should be enough, also you can add conditional constraint on the right e.g. distance should be greater that 20 .

try the tag way it should solve ur issue

YallaDealz commented 3 years ago

ok i will try and back to you with feedback Thanks

MoathOthman commented 3 years ago

@YallaDealz did it work with you ?