search

MobMin / digital_atlas

A detailed overview of the digital and spiritual landscape for the countries of the world.
GNU General Public License v3.0
17 stars 5 forks source link

Laravel Version 10 #34

Closed cprhero7744 closed 3 months ago

cprhero7744 commented 5 months ago

files updated were composer.json, composer.lock, configure\database.php, and tests\Unit\CountryFetchTest.php. Laravel has been upgraded to version 10.43.00

codemis commented 5 months ago

@cprhero7744 Great job on the update! I noticed a few problems with the pull request. You need to test it on PHP 8.2, since Laravel requires that. You probably did not get any errors, because your docker setup did not get rebuilt. Here is how you rebuild it:

First open docker/php-build and change the imaged to php:8.2-fpm-alpine. Now we need to rebuild the images.

docker-compose down
docker-compose build --no-cache
docker-compose up -d

I then logged into the php image, and deleted the vendor directory. I wanted to make sure I have the latest libraries:

docker exec -it da_php /bin/sh 
rm -rf vendor/
exit

Then I reinstall all the vendor files:

docker-compose run --rm da_composer install

Finally, clear your cache:

docker-compose run --rm da_artisan cache:clear

Open the browser, and you will notice several issues. Here are links to address a few of the issues:

  1. Follow the upgrade steps in this repository.
  2. Follow the steps outlined in the first comment here.
  3. You are also missing this library. You can install it using docker-compose run --rm da_composer require arrilot/laravel-widgets. Make sure to clear cache to make it work.

Also, I am not sure how the other pull request got added here. It should be fine. I will test it out once you send an update to the pull request.

codemis commented 3 months ago

Thanks @cprhero7744! I merged this into the develop branch instead of the main branch. You may want to update your fork.