search

MobMin / digital_atlas

A detailed overview of the digital and spiritual landscape for the countries of the world.
GNU General Public License v3.0
17 stars 5 forks source link

git pull #38

Open cprhero7744 opened 2 weeks ago

cprhero7744 commented 2 weeks ago

Larval sails installation

codemis commented 11 hours ago

@cprhero7744 Thank you for your work on this. For some reason I received 2 copies of the pull request. I closed one of them. I am noticing a few issues with the pull request, would you mind looking into them?

  1. You can remove the version number from the docker-compose.yml file. I am receiving a "version is obsolete" warning.
  2. For mysql, the network is sail. Should this be digital_atlas? This issue may be fixed by the next issue.
  3. I think it would be best to use Sails default settings, ie. docker_compose.yml file. It would be super helpful to use the built in commands (sail artisan test) instead of our current docker container commands (docker-compose run --rm da_artisan test) to run php, artisan, node and composer commands. When I try to run the sail commands, it throws the following error: service "laravel.test" is not running

Let me know if you need any clarification on this. Thanks!