Lack of ability to View Source in browser in some cases until upstream EnlighterJS bug is fixed

MobSF / Mobile-Security-Framework-MobSF

Mobile Security Framework (MobSF) is an automated, all-in-one mobile application (Android/iOS/Windows) pen-testing, malware analysis and security assessment framework capable of performing static and dynamic analysis.

https://opensecurity.in

GNU General Public License v3.0

16.93k stars 3.19k forks source link

Lack of ability to View Source in browser in some cases until upstream EnlighterJS bug is fixed #1603

Closed nuschpl closed 3 years ago

nuschpl commented 3 years ago

https://github.com/EnlighterJS/EnlighterJS/issues/144

ajinabraham commented 3 years ago

Waiting for upstream to cut a release. Tracked separately.

nuschpl commented 3 years ago

I doubt it's 'enhancment' I would call it regression as this used to work and now you can't use basic functionality due to fact syntax is colored. Can't we just revert this to work as before untill upstream fix ?

ajinabraham commented 3 years ago

This is out of our control, we switched to this library for the support of line numbers which the previous library has no support for. As it stands the maintainer of EnlighterJS has to release a fix or we are open to PR that could fix the issues while still providing all the existing features.

anantshri commented 2 years ago

faced this today. mid way could be if enlighterjs error is detected then text is presented without the highlight. so usual smaller files work as is. any large file atleast gets listed minus all the funky bits. but i can understand in case @ajinabraham would like to wait for the upstream to fix it as it would probably only affect a small number of people.